fix: [UIE-9258, 9488] - DBaaS Backup / delete dialog bugs by hana-akamai · Pull Request #13355 · linode/manager

hana-akamai · 2026-02-02T22:21:24Z

Description 📝

Fix Database Cluster restore backups / delete dialog bugs

Changes 🔄

Disable Restore button for newest full backup plus incremental option if a first backup hasn't been completed yet
Stop the loading upon error and reset error upon closing for restore dialog
Reset error upon closing delete dialog on the landing page
Minor refactoring

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

Next release

Preview 📷

Restore dialog error	Delete dialog error
error.mov	delete.error.mov

How to test 🧪

Reproduction steps

Backups:

On prod or another branch, create a new cluster
While the cluster is still provisioning, go to the Database cluster's backups tab
The Restore button is enabled for the Newest full backup plus incremental option
Click Restore and then Restore again in the dialog. You should see an error and the loading persists
Close out of the dialog and open it again. The error and loading state persists

Delete:

Go to the Database landing table page, ensure you have at least 2 clusters
Open the network tab and throttle your connection to 3G
Delete a Database cluster via action menu, then quickly delete the same one again before it disappears from the table (faster if TTC is disabled)
You should see an error in the dialog. Close the dialog and open the delete dialog for a different cluster. The error persists

Verification steps

Backups:

Checkout this PR, create a new cluster
While the cluster is still provisioning, go to the Database cluster's backups tab
The Restore button is disabled for the Newest full backup plus incremental option with a tooltip explanation
In DatabaseBackups.tsx line ~318, remove the check for Boolean(unableToRestoreCopy) to enable the restore button
Click Restore and then Restore again in the dialog. You should see an error and loading should stop
Close out of the dialog and open it again. The error and loading states should not persist

Delete:

Go to the Database landing table page, ensure you have at least 2 clusters
Open the network tab and throttle your connection to 3G
Delete a Database cluster via action menu, then quickly delete the same one again before it disappears from the table (faster if TTC is disabled)
You should see an error in the dialog. Close the dialog and open the delete dialog for a different cluster. The error should not persist

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx

hana-akamai · 2026-02-03T22:31:30Z

...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx

          </Typography>
        )}
-        {configs.map((config, index) => (
+        {fields.map((config, index) => (


Squeezing a small bug fix from #13350, no need for changeset since it hasn't been released yet.

Add a config option, then delete it by clicking x, you should not see undefined

linode-gh-bot · 2026-02-03T23:12:55Z

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`864 Passing`	`11 Skipped`	`36m 51s`

Details

Failing Tests
	Spec	Test
❌	`clone-linode.spec.ts`	Cloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

smans-akamai

Followed the different verification steps and the bugs have been addressed! There is one additional change that we should address for the backups bug ticket that I've added in a separate comment.

UPDATE: After reviewing, this will be looked into separately!

smans-akamai · 2026-02-04T16:17:26Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackups.tsx

                disabled={
-                  versionOption === 'dateTime' &&
-                  (!date || !time || !!errors.time)
+                  Boolean(unableToRestoreCopy) ||


For UIE-9258, in addition to the fix for the Backups Restore button disabling behavior, QA had suggested a change to the message we display when the first backup isn't available.

From the comments under the ticket, it isn't clear when the first backup would be completed from the current message. We should address this as part of the work for this ticket as well.

UPDATE: After reviewing, this issue will be looked into separately!

smans-akamai

After discussing the text change mentioned in my other comment, we're going to clarify whether that change needs to be made and handle it in a separate ticket!

For now, the bugs have been resolved, so this pull request should be good to go!

hana-akamai added 3 commits February 2, 2026 17:07

disable restore button if first backup hasn't been completed yet

b803e64

clear errors on close for backups dialog

9621632

clear errors on delete dialog close

7387645

hana-akamai self-assigned this Feb 2, 2026

hana-akamai added the DBaaS Relates to Database as a Service label Feb 2, 2026

github-project-automation bot added this to Cloud Manager Feb 2, 2026

github-project-automation bot moved this to Review in Cloud Manager Feb 2, 2026

hana-akamai and others added 2 commits February 3, 2026 09:44

Merge branch 'develop' into UIE-9258-9488-dbaas-dialog-bugs

a8bec9a

Added changeset: DBaaS Backup / delete dialog bugs

04f3e31

hana-akamai commented Feb 3, 2026

View reviewed changes

...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx Show resolved Hide resolved

hana-akamai marked this pull request as ready for review February 3, 2026 18:10

hana-akamai requested a review from a team as a code owner February 3, 2026 18:10

hana-akamai requested review from aaleksee-akamai, mpolotsk-akamai and smans-akamai February 3, 2026 18:11

bnussman-akamai reviewed Feb 3, 2026

View reviewed changes

...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx Outdated Show resolved Hide resolved

...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx Outdated Show resolved Hide resolved

hana-akamai added 2 commits February 3, 2026 17:24

fix advanced configuration option removal

ad543de

feedback

51318cc

hana-akamai commented Feb 3, 2026

View reviewed changes

hana-akamai requested a review from bnussman-akamai February 3, 2026 22:31

bnussman-akamai approved these changes Feb 4, 2026

View reviewed changes

smans-akamai reviewed Feb 4, 2026

View reviewed changes

smans-akamai approved these changes Feb 4, 2026

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 4, 2026

hana-akamai merged commit 5bf7c78 into linode:develop Feb 4, 2026
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 4, 2026

hana-akamai deleted the UIE-9258-9488-dbaas-dialog-bugs branch February 4, 2026 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [UIE-9258, 9488] - DBaaS Backup / delete dialog bugs#13355

fix: [UIE-9258, 9488] - DBaaS Backup / delete dialog bugs#13355
hana-akamai merged 7 commits intolinode:developfrom
hana-akamai:UIE-9258-9488-dbaas-dialog-bugs

hana-akamai commented Feb 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hana-akamai Feb 3, 2026

Uh oh!

linode-gh-bot commented Feb 3, 2026

Uh oh!

smans-akamai left a comment •

edited

Loading

Uh oh!

smans-akamai Feb 4, 2026

Uh oh!

smans-akamai Feb 4, 2026

Uh oh!

smans-akamai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hana-akamai commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

How to test 🧪

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hana-akamai Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Feb 3, 2026

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

Details

Troubleshooting

Uh oh!

smans-akamai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smans-akamai Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

smans-akamai Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

smans-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hana-akamai commented Feb 2, 2026 •

edited

Loading

smans-akamai left a comment •

edited

Loading